Tidy up command structure for MCP Publisher #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `init` command to create a `server.json` template with detected values from the environment. - Introduced `login` command for authenticating with the registry using various methods (GitHub, DNS, HTTP). - Created `logout` command to clear saved authentication tokens. - Developed `publish` command to publish the `server.json` file to the registry. - Refactored main application logic to utilize the new command structure. - Removed legacy `server.json` file and integrated its creation into the `init` command. - Enhanced error handling and user feedback throughout the commands. :house: Remote-Dev: homespace
🏠 Remote-Dev: homespace
rdimitrov
reviewed
Aug 29, 2025
Member
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
LGTM 👍
One small suggestion is I think we could move the publisher CLI under cmd/. My thinking is that it’s not really a tool in the same sense as the other helpers in the tools/ folder (e.g. validation or dev utilities) and so it's a good practice to have it under cmd/.
Member
Author
|
Nice, ty! Will move under cmd in next PR |
domdomegg
added a commit
that referenced
this pull request
Aug 29, 2025
Move the publisher CLI from tools/publisher/ to cmd/publisher/ as it's a proper application rather than a development utility. Update all references including: - Makefile build and clean targets - README.md documentation links - VS Code launch configuration - Integration test script - FAQ documentation - Go import paths Addresses feedback from PR #324.
domdomegg
added a commit
that referenced
this pull request
Aug 29, 2025
## Summary Move the publisher CLI from `tools/publisher/` to `cmd/publisher/` as it's a proper application rather than a development utility. This addresses feedback from @rdimitrov in PR #324 that the publisher CLI should be under `cmd/` since it's not really a tool in the same sense as other helpers in the `tools/` folder. ## Changes - Moved `tools/publisher/` directory to `cmd/publisher/` - Updated Makefile build and clean targets - Updated README.md documentation links - Updated VS Code launch configuration - Updated integration test script - Updated FAQ documentation - Fixed Go import paths in publisher code --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: adam jones <domdomegg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This builds on the previous cleanup work to further streamline the publisher interface.
This also works as part of #89