-
Notifications
You must be signed in to change notification settings - Fork 555
Check for localhost in remote url #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tadasant / @domdomegg I see we have one testcase which says "allow localhost urls" in validation_test.go. Can you please help clarify what's the expectation here?
|
domdomegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to merge as-is and add the test as a follow-up, will hold open for a few hours so you can add the test to this one if you want :)
|
@Avish34 I think we probably don't want to enable localhost urls, that test is wrong and can be deleted. I think we'll figure out the latest with how we handle local servers in #345 (comment), for now we can disallow them here. |
c3dc613 to
bf63dcb
Compare
|
will fix the merge conflicts for this in a sec |
Merge main into fix-remote-url branch, keeping localhost validation tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
42acc3d to
207222a
Compare
Add check for localhost in remote url.
#274 (comment)
Motivation and Context
We don't want authors to publish server with remote url set as localhost.
How Has This Been Tested?
It has been tested using UTs.
Breaking Changes
Types of changes
Checklist
Additional context