Skip to content

Remove redundant String#dup #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koic merged 1 commit into from
Dec 14, 2025
Merged

Remove redundant String#dup #200

koic merged 1 commit into from
Dec 14, 2025
+1 −1

Conversation

@koic
Copy link
Member

@koic koic commented Dec 14, 2025

Motivation and Context

Since no destructive methods are being called, dup isn’t necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@koic
Remove redundant String#dup
0429284 
Since no destructive methods are being called, `dup` isn’t necessary.
@koic koic merged commit 0b70ef3 into modelcontextprotocol:main Dec 14, 2025
6 checks passed
@koic koic deleted the remove_redundant_string_dup branch December 14, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atesgoral atesgoral atesgoral approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koic @atesgoral