[Doc] Fix Rails controller example to return 202 for notifications#252
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
The previous example used `Server#handle_json` directly, which does not control HTTP status codes. Notifications such as `notifications/initialized` require 202 Accepted per the MCP spec, but the example always returned 200. Use `StreamableHTTPTransport#handle_request` instead, which returns the correct HTTP status code for each request type. - https://modelcontextprotocol.io/specification/2025-03-26/basic/transports#sending-messages-to-the-server - https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#sending-messages-to-the-server Closes modelcontextprotocol#158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The previous example used
Server#handle_jsondirectly, which does not control HTTP status codes. Notifications such asnotifications/initializedrequire 202 Accepted per the MCP spec, but the example always returned 200.Use
StreamableHTTPTransport#handle_requestinstead, which returns the correct HTTP status code for each request type.Closes #158
Types of changes
Checklist