chore(rmcp): remove dependency on chrono default features#829
Open
chitao1234 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
chore(rmcp): remove dependency on chrono default features#829chitao1234 wants to merge 1 commit intomodelcontextprotocol:mainfrom
chitao1234 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
chronodefault features for non-wasmrmcpbuilds and enable only the featuresrmcpactually uses. This avoids pulling unnecessary local-timezone support such asiana-time-zone/iana-time-zone-haiku, which can introduce avoidable platform library dependencies on Haiku. Fixes #828.Motivation and Context
Issue #828 reports that
rmcp’s nativechronodependency leaves default features enabled, which pulls in local-timezone support thatrmcpdoes not use. On Haiku, that can bring iniana-time-zone-haikuandlibbe.so, contributing to downstream link failures when combined with vendoredzstd.This change narrows the native
chronodependency todefault-features = falsewith only["serde", "now"]enabled. That keeps the functionalitiesrmcpuses while avoiding the extra dependency footprint fromchronodefaults.How Has This Been Tested?
cargo test -p rmcp,cargo test -p rmcp --all-featuresandcargo test --workspace --allunder Linux x86_64Breaking Changes
None.
Types of changes
Checklist
Additional context
See #828.