fix: standardize search parameter naming to 'q'#1242
Closed
soumilsuri wants to merge 1 commit into
Closed
Conversation
Fix inconsistency in search parameter naming where some operations used 'query' while others used 'q'. This standardizes all search operations to use 'q' to match GitHub's API naming convention, preventing confusion for LLMs using the tools.
olaservo
reviewed
Apr 18, 2025
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
A couple things:
- This appears to be a breaking change but I don't see that called out in the description?
queryseems more user-friendly than justq?
Member
|
Deprecation Notice: Development for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency in parameter naming between different search operations. Some operations were using
query(specifically inSearchRepositoriesSchema) while others were usingq. This caused confusion for LLMs when using these tools.Changes
SearchRepositoriesSchemafromquerytoqsearchRepositories()function signature to matchTesting
Related Issues
Fixes #1080 (GitHub MCP Server: "q" vs "query" in parameters)
This change is a straightforward parameter naming standardization to improve consistency across the codebase.