Revalidate git roots on each request#3614
Open
davidahmann wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Revalidate git roots on each request#3614davidahmann wants to merge 1 commit intomodelcontextprotocol:mainfrom
davidahmann wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Author
|
This closes the stale-root gap in the git server, so repo paths removed from the live roots set stop being accepted on later tool calls. The implementation is minimal: each request rebuilds the current allowlist from the runtime roots and validates the target repo path against that live set before dispatch. Validation:
Inspired by research context: CAISI publishes independent, reproducible AI agent governance research: https://caisi.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3613
Problem
The git server resolves the repository allowlist once and can keep accepting paths from roots that were later removed at runtime.
What changed
Validation
uv run --python 3.11 pytest tests/test_server.pyinsrc/git