Skip to content

Conversation

@mattzcarey
Copy link
Contributor

@mattzcarey mattzcarey commented Nov 3, 2025

Updates node from 18 to current LTS (24) in Github CI as it is entering EOL in the new year.

Tests against both the oldest legacy version we should support until April (18) and current LTS (24).
I would strongly suggest we upgrade our oldest version to 22 soon.

Motivation and Context

Screenshot 2025-11-03 at 17 06 06

How Has This Been Tested?

Tests test against both versions. We just build in the newer version so we can use tsdown. #1071

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@mattzcarey mattzcarey requested a review from a team as a code owner November 3, 2025 17:10
@mattzcarey mattzcarey changed the title Update Node LTS in ci Update to Node LTS Nov 3, 2025
@mattzcarey mattzcarey changed the title Update to Node LTS Upgrade to Node LTS Nov 3, 2025
package.json Outdated
"engines": {
"node": ">=18"
"node": ">=18",
"npm": ">=10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the NPM upgrade intentional? Apparently node 18 ships with older npm versions, might be an inadvertently breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it shipped with 10+ but yep I'm wrong. Will remove:

  {
    "version": "v18.0.0",
    "date": "2022-04-18",
    "files": [
      "aix-ppc64",
      "headers",
      "linux-arm64",
      "linux-armv7l",
      "linux-ppc64le",
      "linux-s390x",
      "linux-x64",
      "osx-arm64-tar",
      "osx-x64-pkg",
      "osx-x64-tar",
      "src",
      "win-x64-7z",
      "win-x64-exe",
      "win-x64-msi",
      "win-x64-zip"
    ],
    "npm": "8.6.0",
    "v8": "10.1.124.8",
    "uv": "1.43.0",
    "zlib": "1.2.11",
    "openssl": "3.0.2+quic",
    "modules": "108",
    "lts": false,
    "security": false
  },

@mattzcarey mattzcarey mentioned this pull request Nov 4, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants