Skip to content

Conversation

@mattzcarey
Copy link
Contributor

@mattzcarey mattzcarey commented Nov 7, 2025

CI is failing due to a change in https://raw.githubusercontent.com/modelcontextprotocol/modelcontextprotocol/266e9a86edbe590bfa8d34d89527d70793b3ce53/schema/draft/schema.ts which is getting pulled into our spec.types.ts

This PR moves to a Nightly cycle where every day an action runs checking that file for changes and opening a PR. Because that file now lives in this repo we shouldn't see flaky CI runs.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@mattzcarey mattzcarey requested a review from a team as a code owner November 7, 2025 11:10
@mattzcarey mattzcarey changed the title feat: use a nightly spec.types.ts FIX: use a nightly spec.types.ts Nov 7, 2025
Copy link
Member

@pcarleton pcarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks. Is there a way to test run it pre-merge?

@mattzcarey
Copy link
Contributor Author

mattzcarey commented Nov 7, 2025

Not really. There is a Docker based Github runner thingy but it wont deal with permissions issues which is probably the main worry here. I have tested it locally as a script and it runs fine but I can't test it with the Github token associated with the Github bot account. When you merge you can run the action manually to confirm. It should be fine tho I back it :)

Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattzcarey!

@felixweinberger felixweinberger merged commit 4463737 into modelcontextprotocol:main Nov 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants