feat: Add Zod 4 support while maintaining Zod 3 compatibility #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
- Move zod to peerDependencies supporting ^3.23.8 || ^4.0.0 - Create zodJsonSchema wrapper with auto-detection - Use native z.toJSONSchema() for Zod 4 - Fall back to zod-to-json-schema for Zod 3 - Add ZOD_4_MIGRATION.md documentation - Non-breaking change, fully backward compatible Closes modelcontextprotocol#555 Amp-Thread-ID: https://ampcode.com/threads/T-6db05869-7946-4144-922f-b7adac392de5 Co-authored-by: Amp <amp@ampcode.com>
jackkoppa
force-pushed
the
feat/zod-4-support
branch
2 times, most recently
from
2440086 to
c34efde
Compare
The RegisteredTool type now preserves the original ZodRawShape instead of converting it to ZodType<object>. This allows users to access shape properties directly, which is important for introspection and testing. The conversion to ZodType<object> is now done only when needed: - During JSON schema generation (for API responses) - During validation (for parsing input/output) This is a non-breaking fix that maintains backward compatibility.
jackkoppa
force-pushed
the
feat/zod-4-support
branch
from
c34efde to
0b2ef19
Compare
Author
|
Closing out this PR. The primarily AI-generated changes did not result in a working version of /sdk that I could use in our Zod4 codebase, and I won't have time to pursue this further for at least the next few weeks. Please feel free, obviously, to reference this in another PR attempting to add Zod4 support. |
9 tasks
|
@jackkoppa would this PR be helpful? #1113 Zod 4 schema won't be supported still, but at least users can use the latest Zod version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
@jackkoppa - Closing out this PR. The primarily AI-generated changes did not result in a working version of
/sdkthat I could use in our Zod4 codebase, and I won't have time to pursue this further for at least the next few weeks. Please feel free, obviously, to reference this in another PR attempting to add Zod4 support.Warning
@jackkoppa - This is only a first attempt, and before this is possibly opened for review, would love to see what CI errors are raised. Heavily AI-assisted first pass (via Amp). Please don't spend any time reviewing yet! Thanks!Closes #555
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context