Fix optional argument handling in prompts for Zod V4 #1199
Merged
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
filip-bartuska-ipf
force-pushed
the
optional-prompt-arg-reproduce
branch
from
36369f4 to
4c9cb56
Compare
mattzcarey
approved these changes
Dec 1, 2025
Contributor
mattzcarey
left a comment
mattzcarey
left a comment
There was a problem hiding this comment.
LGTM. tested and approved
felixweinberger
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing seemingly carried over types/expectations from Zod V3 into Zod V4, which test for internal properties which no longer exist, which caused optional properties to not be identified and propagated in prompts in Zod V4.
Motivation and Context
Fixes a bug, which makes optional fields impossible in prompts using Zod V4.
Bug/issue description: #1198
How Has This Been Tested?
Reproduced and tested using a unit test.
I've also tested it in our internal code, which is the main reason for this MR.
Breaking Changes
Potentially, as the behavior changes from ignoring optional properties to properly propagating them.
Types of changes
Checklist
Additional context