feat: add closeStandaloneSSEStream for GET stream polling #1203
+310
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
pcarleton
approved these changes
Dec 1, 2025
TDD setup for closing standalone GET SSE streams via extra callback. Tests added: - should provide closeStandaloneSSEStream callback in extra (passes) - should close standalone GET SSE stream when extra.closeStandaloneSSEStream is called (fails) - should allow client to reconnect after standalone SSE stream is closed (fails) Also updated existing closeSSEStream test to use extra.closeSSEStream() for consistency (all stream close tests now use the extra callback API). Stub implementation added - tests fail with "Stream did not close in time"
Implement the ability to close standalone GET SSE streams, enabling polling behavior for server-initiated notifications (SEP-1699). Changes: - closeStandaloneSSEStream() now closes the GET stream by ending the response and removing from stream mapping - Events are now stored even when standalone stream is disconnected, allowing replay on client reconnect with Last-Event-ID This complements the existing closeSSEStream() for POST streams.
felixweinberger
force-pushed
the
fweinberger/closeSSEStream-standalone
branch
from
310d3b2 to
de41e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closeStandaloneSSEStream()method to close standalone GET SSE streamsextra.closeStandaloneSSEStream()callback in request handlersThis enables SEP-1699 polling behavior for standalone GET streams, complementing the existing
closeSSEStream()for POST streams.Motivation and Context
SEP-1699 allows servers to disconnect SSE streams at will to implement polling patterns. The existing
closeSSEStream()only works for POST-based streams. This PR adds support for closing the standalone GET stream as well.How Has This Been Tested?
closeStandaloneSSEStreamcallback availabilityextra.closeStandaloneSSEStream()Last-Event-IDafter server-initiated disconnectcloseSSEStreamtest to useextra.closeSSEStream()for consistencyBreaking Changes
None - this is additive functionality.
Types of changes
Checklist
Additional context
Depends on #1166 (closeSSEStream callback PR).