fix(streamableHttp): fix infinite retries when maxRetries is set to 0 #1216
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
approved these changes
Dec 2, 2025
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
Good find thanks
commit: |
Fix formatting issues that were causing CI to fail: - Correct indentation on `let transport` declaration - Remove trailing whitespace - Remove extra blank line
The previous test didn't properly exercise _scheduleReconnection. This improved test: - Directly tests _scheduleReconnection with maxRetries=0 - Verifies the "Maximum reconnection attempts (0) exceeded" error - Confirms no setTimeout is scheduled (no retry attempt) - Adds a companion test for maxRetries>0 to verify normal behavior
Contributor
|
Made some changes to the tests + fixed CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1179
Fixes invalid conditional check by removing
maxRetries > 0Motivation and Context
Incorrect logic
How Has This Been Tested?
test suite passes, 1 test added to verify change
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context