fix: prevent Hono from overriding global Response object #1410
+127
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ddf200 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Pass `overrideGlobalObjects: false` to `getRequestListener()` calls in NodeStreamableHTTPServerTransport to prevent Hono from overwriting the global Response object. This fixes an issue where frameworks like Next.js whose response classes extend the native Response would break after initializing MCP transport, as `instanceof Response` checks would fail. Fixes #1369
mattzcarey
force-pushed
the
fix/hono-override-global-objects
branch
from
2a43bfc to
2bf9b8f
Compare
pcarleton
approved these changes
Jan 20, 2026
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
overrideGlobalObjects: falsetogetRequestListener()calls inNodeStreamableHTTPServerTransportResponseobjectResponseis preserved after transport initializationProblem
When
StreamableHTTPServerTransportis instantiated, Hono'sgetRequestListener()overwrites the globalResponseobject with its own implementation (by default). This breaks frameworks like Next.js whoseNextResponseclass extends the nativeResponse, causinginstanceof Responsechecks to fail.Fixes #1369
Test plan
Responseis not overwritten after transport constructionResponseis not overwritten afterhandleRequestis called