fix: add missing size field to ResourceSchema per MCP spec#1600
Open
giulio-leone wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
fix: add missing size field to ResourceSchema per MCP spec#1600giulio-leone wants to merge 3 commits intomodelcontextprotocol:mainfrom
giulio-leone wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c9acbd1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
Author
|
All CI checks pass. Ready for review. |
added 3 commits
March 6, 2026 17:17
The MCP specification (revisions 2025-06-18, 2025-11-25, and draft) defines an optional `size?: number` field on the Resource interface for declaring raw resource content size in bytes. This field was missing from the TypeScript SDK's ResourceSchema Zod definition. Fixes modelcontextprotocol#1573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP specification (revisions 2025-06-18, 2025-11-25, and draft) defines an optional
size?: numberfield on theResourceinterface:This field is missing from the TypeScript SDK's
ResourceSchemaZod definition.Fix
Added
size: z.optional(z.number())toResourceSchemainsrc/types.ts.Since
ResourceMetadatais derived asOmit<Resource, 'uri' | 'name'>, servers can immediately passsizein resource metadata and it will be included inresources/listresponses.Test
Added 1 test verifying that a resource registered with
size: 102400correctly returns the size field in theresources/listresponse.Verification
2 consecutive clean test runs: 1549/1549 tests passed, 0 failures.
Fixes #1573