v2 fix: Update spec types to latest; replace AssertObjectSchema with proper JSON type schemas#1612
Merged
KKonstantinov merged 5 commits intomodelcontextprotocol:mainfrom Mar 5, 2026
Conversation
Replace the internal AssertObjectSchema (z.custom<object>) with proper Zod schemas (JSONValueSchema, JSONObjectSchema, JSONArraySchema) that produce correct JSON types, aligning the SDK's inferred types with the spec. This eliminates the need for most FixSpec workarounds in the type compatibility tests. Also syncs spec.types.ts and adds missing SDK types (error codes, ResultResponse types, MetaObject types) to pass spec type checks.
|
KKonstantinov
changed the title
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
KKonstantinov
changed the title
v2 fix: replace AssertObjectSchema with proper JSON type schemas, align spec types
KKonstantinov
changed the title
v2 fix: replace AssertObjectSchema with proper JSON type schemas, align spec typesv2 fix: Update spec types to latest; replace AssertObjectSchema with proper JSON type schemas
KKonstantinov
added
the
v2
felixweinberger
approved these changes
Mar 5, 2026
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating this straight away and for submitting the SEP in the first place! This looks nice now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the internal AssertObjectSchema (z.custom) with proper Zod schemas (JSONValueSchema, JSONObjectSchema, JSONArraySchema) that produce correct JSON types, aligning the SDK's inferred types with the spec.
Also syncs spec.types.ts and adds missing SDK types (error codes, ResultResponse types, MetaObject types) to pass spec type checks.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context