fix: always set windowsHide on Windows for stdio transport#1706
Open
ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: always set windowsHide on Windows for stdio transport#1706ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Set windowsHide to true for all Windows apps, not just Electron. Non-Electron apps (e.g., VS Code extensions, CLI tools) also show an empty cmd.exe console window when spawning MCP servers via stdio. Remove the now-unused isElectron() helper. Fixes modelcontextprotocol#1638
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
windowsHidetotruefor all Windows apps when spawning MCP servers via stdio, not just Electron apps. This prevents an empty cmd.exe console window from appearing.Problem
The current code only sets
windowsHide: truewhen running inside Electron:Non-Electron Windows apps (VS Code extensions, CLI tools, etc.) also spawn MCP servers and get an unwanted console window.
Fix
windowsHide: process.platform === 'win32'isElectron()helperThe
windowsHideoption is a no-op on non-Windows platforms, so this is safe to always set on Windows.Fixes #1638