fix(examples): return 404 for invalid session IDs#1707
Open
owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix(examples): return 404 for invalid session IDs#1707owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Fixes modelcontextprotocol#389 The streamable HTTP server examples were returning 400 for both missing and invalid session IDs. Per the MCP spec: - Missing session ID (non-init request) → 400 Bad Request - Invalid session ID (not found) → 404 Not Found The 404 status is important because it signals to clients that they should start a new session (per spec: 'When a client receives HTTP 404 in response to a request containing an Mcp-Session-Id, it MUST start a new session'). Updated the following examples: - jsonResponseStreamableHttp.ts - simpleStreamableHttp.ts (POST, GET, DELETE handlers) - standaloneSseWithGetStreamableHttp.ts (POST, GET handlers) - elicitationFormExample.ts (POST, GET, DELETE handlers) - elicitationUrlExample.ts (POST, GET, DELETE handlers) - simpleTaskInteractive.ts (POST, GET, DELETE handlers)
🦋 Changeset detectedLatest commit: 64c7a4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #389
The streamable HTTP server examples were returning HTTP 400 for both missing and invalid session IDs. Per the MCP spec, these should be handled differently:
The 404 status is important because it signals to clients that they should start a new session. Per the spec:
Changes
Updated all streamable HTTP examples to differentiate between missing and invalid session IDs:
jsonResponseStreamableHttp.tssimpleStreamableHttp.ts(POST, GET, DELETE handlers)standaloneSseWithGetStreamableHttp.ts(POST, GET handlers)elicitationFormExample.ts(POST, GET, DELETE handlers)elicitationUrlExample.ts(POST, GET, DELETE handlers)simpleTaskInteractive.ts(POST, GET, DELETE handlers)Testing
Manually verified the logic by code review. The changes are straightforward: split the existing
!sessionId || !transports[sessionId]checks into separate conditions with appropriate status codes.Spec Reference
From the MCP Transport specification: