fix(express): add CJS exports to resolve ERR_PACKAGE_PATH_NOT_EXPORTED#1911
Open
langverse2023 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(express): add CJS exports to resolve ERR_PACKAGE_PATH_NOT_EXPORTED#1911langverse2023 wants to merge 1 commit intomodelcontextprotocol:mainfrom
langverse2023 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The @modelcontextprotocol/express package only exported ESM (.mjs) format, causing ERR_PACKAGE_PATH_NOT_EXPORTED for consumers using CommonJS/require(). Add CJS output format to tsdown config and corresponding require entries in the package.json exports field, so both ESM and CJS consumers can resolve the package correctly. Fixes modelcontextprotocol#1858
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1858
The
@modelcontextprotocol/expresspackage only defines ESM (.mjs) entries in itsexportsfield, which causesERR_PACKAGE_PATH_NOT_EXPORTEDfor consumers using CommonJS (require()). This is a common scenario for TypeScript projects initialized with defaulttsconfig.jsonsettings (e.g.module: "commonjs").Changes
tsdown.config.ts: Add'cjs'to theformatarray so tsdown generates both.mjsand.cjsoutput filespackage.json: Addrequireconditions to theexportsfield for both the main entry and type definitionsBefore
After
Test plan
pnpm --filter @modelcontextprotocol/express buildsucceeds, generating both ESM and CJS outputpnpm --filter @modelcontextprotocol/express testpasses (17/17 tests)require('@modelcontextprotocol/express')without errors