fix(server): loosen Accept validation when enableJsonResponse is true#1952
Open
Zelys-DFKH wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
When enableJsonResponse is true, StreamableHTTPServerTransport responds with a plain JSON body and never opens an SSE stream, so requiring text/event-stream in the Accept header is incorrect. The check now only requires application/json in that mode. Default SSE streaming mode is unchanged: both media types are still required. Fixes modelcontextprotocol#1944.
🦋 Changeset detectedLatest commit: caee461 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`WebStandardStreamableHTTPServerTransport` returns 406 when a client sends `Accept: application/json` (without `text/event-stream`) even when the transport is constructed with `enableJsonResponse: true`.
That's the wrong check. With `enableJsonResponse: true`, the server responds with a plain JSON body and never opens an SSE stream. Requiring the client to advertise `text/event-stream` is unnecessary: the media type isn't used, and it breaks clients that send a minimal `Accept: application/json` (a standard JSON-RPC default). The AdCP ecosystem currently works around this with an Express middleware that rewrites the header before the transport sees it.
`handlePostRequest` now reads `this._enableJsonResponse` when validating the Accept header:
This change doesn't touch the GET handler or the SSE response path. `NodeStreamableHTTPServerTransport` is covered as well since it delegates request handling to `WebStandardStreamableHTTPServerTransport`.
Test plan
Fixes #1944