Skip to content

fix: enforce monotonic progress notifications#1982

Open
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Genmin:fix/progress-monotonicity-timeout
Open

fix: enforce monotonic progress notifications#1982
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Genmin:fix/progress-monotonicity-timeout

Conversation

@Genmin
Copy link
Copy Markdown

@Genmin Genmin commented Apr 29, 2026

Summary

Fixes #1001.

Progress notifications now track the last reported progress value per in-flight request and reject non-increasing updates before they can reset the request timeout or reach the progress callback. The tracking state is cleared anywhere the progress handler is removed, including normal responses, cancellations, task cleanup, and connection close.

Validation

  • pnpm --filter @modelcontextprotocol/core test -- packages/core/test/shared/protocol.test.ts -t "progress notification timeout behavior"
  • pnpm --filter @modelcontextprotocol/core typecheck
  • pnpm --filter @modelcontextprotocol/core lint
  • pre-push hook: typecheck:all, build:all, lint:all

@Genmin Genmin requested a review from a team as a code owner April 29, 2026 23:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

🦋 Changeset detected

Latest commit: 0fde67b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modelcontextprotocol/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@1982

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@1982

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@1982

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@1982

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@1982

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@1982

commit: 0fde67b

@Genmin
Copy link
Copy Markdown
Author

Genmin commented Apr 30, 2026

Added the missing patch changeset for the touched core package. The previous red matrix jobs were isolated to the unrelated Miniflare Cloudflare Worker Network connection lost failure, so this should at least clear the release-metadata blocker and trigger a fresh run.

@Genmin Genmin force-pushed the fix/progress-monotonicity-timeout branch from 2e14638 to 0fde67b Compare April 30, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report-3: Missing Progress Monotonicity Validation Leading to Resource Exhaustion

1 participant