fix: enforce monotonic progress notifications#1982
Open
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: enforce monotonic progress notifications#1982Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 0fde67b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Added the missing patch changeset for the touched core package. The previous red matrix jobs were isolated to the unrelated Miniflare Cloudflare Worker |
2e14638 to
0fde67b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1001.
Progress notifications now track the last reported progress value per in-flight request and reject non-increasing updates before they can reset the request timeout or reach the progress callback. The tracking state is cleared anywhere the progress handler is removed, including normal responses, cancellations, task cleanup, and connection close.
Validation