Skip to content

fix: pin vite to patched version#2050

Open
raashish1601 wants to merge 1 commit into
modelcontextprotocol:mainfrom
raashish1601:codex/2048-high-severity-cves-via-pnpm-audit
Open

fix: pin vite to patched version#2050
raashish1601 wants to merge 1 commit into
modelcontextprotocol:mainfrom
raashish1601:codex/2048-high-severity-cves-via-pnpm-audit

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

  • Add a direct patched vite devDependency so pnpm resolves Vitest's Vite dependency away from the vulnerable range reported in High-severity CVEs via pnpm audit #2048.
  • Refresh pnpm-lock.yaml accordingly.

Fixes #2048.

Validation

  • corepack pnpm install
  • corepack pnpm -r typecheck
  • corepack pnpm audit --audit-level=high | Select-String vite returns no matches
  • corepack pnpm -r lint still fails on existing baseline Prettier warnings across unrelated files

@raashish1601 raashish1601 requested a review from a team as a code owner May 11, 2026 16:58
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 11, 2026

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2050

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2050

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2050

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2050

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2050

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2050

commit: d6d23b5

@morozow
Copy link
Copy Markdown

morozow commented May 11, 2026

This is a valid short-term CVE fix, but it also changes dependency ownership.
By adding Vite directly, the SDK workspace now has to maintain Vite alignment itself, although Vite is only needed through Vitest/tooling and not through the SDK runtime. Future Vitest/Vite compatibility changes or audit findings may therefore require direct maintenance in this repo.

That means future Vitest updates, Vite compatibility changes, or new Vite audit findings may require this SDK repo to keep adapting a direct Vite dependency. For a long-lived open-source SDK, this creates additional toolchain coupling that should probably be considered separately from the immediate severity fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High-severity CVEs via pnpm audit

2 participants