fix(packaging): expose Ajv from CJS validator subpaths#2431
Open
morluto wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c269c39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CommonJS
validators/ajvsubpath export for both@modelcontextprotocol/serverand@modelcontextprotocol/client. In CommonJS consumers, readingAjvfrom either AJV validator subpath currently throwsReferenceError: import_ajv is not defined.The CJS build was preserving
Ajvas a live getter but leaving it pointed at an ESM-only local alias (import_ajv). ExportingAjvas a concrete local value from the provider makes the generated CJS subpath re-exportrequire_ajvProvider.Ajv, matching the actual CJS provider module.Adds regression coverage through the existing dist/barrel tests by requiring the built CJS validator subpath and constructing
Ajv,addFormats, andAjvJsonSchemaValidator.Fixes #2430.
Verification
pnpm --filter @modelcontextprotocol/server --filter @modelcontextprotocol/client buildnode -e "const m = require('./packages/server/dist/validators/ajv.cjs'); new m.Ajv({ strict: false })"node -e "const m = require('./packages/client/dist/validators/ajv.cjs'); new m.Ajv({ strict: false })"pnpm --filter @modelcontextprotocol/server test -- test/server/barrelClean.test.tspnpm --filter @modelcontextprotocol/client test -- test/client/barrelClean.test.tspnpm --filter @modelcontextprotocol/core-internal test -- test/validators/validators.test.tsnode scripts/smoke-dist-types.mjsgit diff --check