feat: add optional resource annotations #954
Merged
+128
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
force-pushed
the
main
branch
from
1d475bb to
0845a57
Compare
felixweinberger
force-pushed
the
main
branch
from
0845a57 to
c94ba4b
Compare
commit: |
Contributor
|
Hello. Thank you for your work on this. Got my eyes on this PR and have updated it to the latest, as well as added Need to add some tests to lock it down for all the other types which now include Will follow this through. |
KKonstantinov
added
the
improves spec compliance
KKonstantinov
approved these changes
Dec 3, 2025
Contributor
|
Thank you for your work! Apologies about the wait time here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #946 by adding type definitions for the optional annotations attribute for resources.
Also adds tests to validate the schema -> SDK typings and creation of a resource with annotations