Skip to content

Clarify that only sub-directories containing package.mo are considered for conflict#3885

Merged
HansOlsson merged 4 commits intomodelica:masterfrom
HansOlsson:ExternalResourceConflict
Apr 28, 2026
Merged

Clarify that only sub-directories containing package.mo are considered for conflict#3885
HansOlsson merged 4 commits intomodelica:masterfrom
HansOlsson:ExternalResourceConflict

Conversation

@HansOlsson
Copy link
Copy Markdown
Collaborator

Closes #3882

@HansOlsson HansOlsson requested a review from henrikt-ma April 23, 2026 11:25
@HansOlsson HansOlsson added the clarification Specification of feature is unclear, but not incorrect label Apr 23, 2026
Comment thread chapters/packages.tex
Comment thread chapters/packages.tex Outdated
@henrikt-ma
Copy link
Copy Markdown
Collaborator

I miss the normative change that makes it clear that a directory only qualifies as an entry if it contains package.mo (as opposed to qualifying by only being a directory, and than having to fulfill the requirement to contain package.mo).

That is, replace this:

The nature of such an external entity falls into one of the following two groups:
\begin{itemize}
\item
  Directory in the file system.
\end{itemize}

\begin{itemize}
\item
  File in the file system.
\end{itemize}

by this:

The nature of such an external entity in the file system falls into one of the following two groups:
\begin{itemize}
\item
  A directory containing a file named \filename{package.mo}.
\item
  A file with filename extension \filename{mo}.
\end{itemize}

Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need normative rules outside the example, and no rules should be given in the example.

Comment thread chapters/packages.tex Outdated
@HansOlsson HansOlsson requested a review from henrikt-ma April 28, 2026 11:16
Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll try to take it from here in a separate PR that is not urgent to merge.

@HansOlsson HansOlsson merged commit 0463019 into modelica:master Apr 28, 2026
1 check passed
@HansOlsson HansOlsson deleted the ExternalResourceConflict branch April 28, 2026 13:05
@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clarification Specification of feature is unclear, but not incorrect M37 For pull requests merged into Modelica 3.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between external resources and directory hierarchy mapping?

3 participants