Skip to content

Update release notes for beta.2#2592

Merged
beutlich merged 1 commit intomodelica:masterfrom
beutlich:update-release-notes
Jun 6, 2018
Merged

Update release notes for beta.2#2592
beutlich merged 1 commit intomodelica:masterfrom
beutlich:update-release-notes

Conversation

@beutlich
Copy link
Member

@beutlich beutlich commented Jun 5, 2018

  • list of resolved GitHub issues (including pull requests) generated by python Generate-ReleaseNotes.py
  • comparison table between v3.2.3 and v3.2.2 generated by ModelManagement.Compare.compareModels("Modelica323", "Modelica 3.2.3", "Modelica322", "Modelica 3.2.2", "DifferencesTo322.html", true)

@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Jun 5, 2018
@beutlich beutlich added this to the MSL3.2.3 milestone Jun 5, 2018
@beutlich beutlich self-assigned this Jun 5, 2018
@beutlich beutlich requested review from AHaumer and dietmarw June 5, 2018 20:24
@beutlich beutlich force-pushed the update-release-notes branch 2 times, most recently from a5442a1 to 73eb5d9 Compare June 5, 2018 20:35
@AHaumer AHaumer requested a review from christiankral June 5, 2018 21:02
@AHaumer
Copy link
Contributor

AHaumer commented Jun 5, 2018

Sorry nearly impossible to track changes that late after a long day. Tomorrow I'm travelling, you might add other reviewers.

AHaumer
AHaumer previously approved these changes Jun 6, 2018
@christiankral
Copy link
Contributor

Why are we using font "Arial" in the HTML code? I suppose, the HTML editor of Dymola is inserting this, but maybe I am wrong... However, I think we should rather avoid "Arial" -- which I am not using anyways, as Linux user -- and we should avoid any other font name and leave this up the HTML engine.

I will have a look at the content around 10-11 this morning.

@beutlich
Copy link
Member Author

beutlich commented Jun 6, 2018

Why are we using font "Arial" in the HTML code? I suppose, the HTML editor of Dymola is inserting this

Indeed, it is generated by running ModelManagement.Compare.compareModels in Dymola on Windows. That is also how it is in MSL v3.2.2, see e.g., https://doc.modelica.org/Resources/Documentation/Version-3.2.2/Differences322To321Build4.html.

* list of resolved GitHub issues (including pull requests) generated by `python Generate-ReleaseNotes.py`
* comparison table between v3.2.3 and v3.2.2 generated by `ModelManagement.Compare.compareModels("Modelica323", "Modelica 3.2.3", "Modelica322", "Modelica 3.2.2", "DifferencesTo322.html", true)`
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ResolvedGutHubIssues.html is a valid html-file with a valid doctype. DifferencesTo322.html however lacks a DOCTYPE and is neither a valid HTML4 or HTML5 document; it doesn't close HTML entities, messes up table tags a lot, etc... But I guess we can't do much about that.

@beutlich beutlich merged commit eea7443 into modelica:master Jun 6, 2018
@beutlich beutlich deleted the update-release-notes branch June 6, 2018 06:20
@beutlich
Copy link
Member Author

beutlich commented Jun 6, 2018

But I guess we can't do much about that.

@HansOlsson or @StephanZiegler might take on improving the HTML validity of ModelManagement.Compare.compareModels in Dymola.

@beutlich beutlich added the V: 3.2.3-beta.1 Issue originates in MSL v3.2.3-beta.1 (and is not present in earlier releases) label Jun 14, 2018
@beutlich beutlich removed the request for review from christiankral June 15, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Resources Issue addresses Modelica/Resources (excl. C-Sources) V: 3.2.3-beta.1 Issue originates in MSL v3.2.3-beta.1 (and is not present in earlier releases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants