Skip NULL checks for passed external objects#4406
Merged
casella merged 1 commit intomodelica:masterfrom Jun 22, 2024
Merged
Conversation
beutlich
added
L: Resources
henrikt-ma
reviewed
May 23, 2024
maltelenz
approved these changes
May 23, 2024
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
Seems fine to me.
I would say Modelica 3.7 is not required.
HansOlsson
approved these changes
May 24, 2024
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Seems ok.
However, an alternative would be to have the assert first and then keep the previous checks - that would be slightly more robust.
I don't know if the NULL pointer checks are that costly.
Member
Author
|
We have it in M_DD without NULL checks for years. Thus it rather is an issue of code style than technical necessity. |
beutlich
force-pushed
the
expec-non-null
branch
2 times, most recently
from
4ebac49 to
be51800
Compare
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in line with modelica-3rdparty/Modelica_DeviceDrivers#153 and specification change/clarification for modelica/ModelicaSpecification#3500.
I labeled with
requires Modelica 3.7, but I am actually not sure.