Skip to content

Fix wrong expression in dp_volumeFlowRate_MFLOW#4553

Merged
casella merged 1 commit intomodelica:masterfrom
casella:fix_4552
Mar 7, 2025
Merged

Fix wrong expression in dp_volumeFlowRate_MFLOW#4553
casella merged 1 commit intomodelica:masterfrom
casella:fix_4552

Conversation

@casella
Copy link
Contributor

@casella casella commented Feb 26, 2025

Fixes #4552.

Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looking good and it fixes one of the unit-issues in the model.

(The other is the somewhat sloppy assert(a+b>0, "...") - but no need to rewrite that for 4.1.0.)

@casella casella enabled auto-merge (squash) March 1, 2025 17:28
@beutlich beutlich added bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation labels Mar 3, 2025
@casella
Copy link
Contributor Author

casella commented Mar 7, 2025

@maltelenz I need you help here. Stefan Wisschhusen gave me thumbs up by email 10 days ago

Hey Francesco,

many thanks for the issue report! Well, obviously you are right 😊. Vflow = dp/b.

but he's probably too busy to take care of this, as he resigned from MAP-Lib long time ago. @hubertus65 and @arunkumar-narasimhan are also probably busy with other stuff.

Please accept this so we can merge it in, @Esther-Devakirubai can merge it in, and we can move on with the release.

Thanks!

Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as requested by @casella .

(FYI I'm unavailable until 17th of March, so will be unable to help with any real MSL work until then.)

@casella casella merged commit 9248653 into modelica:master Mar 7, 2025
2 checks passed
@Esther-Devakirubai
Copy link
Contributor

Backported by #4580

@MatthiasBSchaefer
Copy link
Contributor

The case a=0 and b>0 , corrected here, is -as far as i can see - not covered by any example model in Modelica or ModelicaTest. Maybe this should be done by enhancing the example ModelicaTest.Fluid.Dissipation.Verifications.PressureLoss.General.dp_volumeFlowRate_DPMFLOW

casella added a commit that referenced this pull request Mar 10, 2025
Co-authored-by: Francesco Casella <francesco.casella@polimi.it>
@casella
Copy link
Contributor Author

casella commented Mar 10, 2025

The case a=0 and b>0 , corrected here, is -as far as i can see - not covered

That's true. This is really a Herculean task, it's like slashing the heads of the Hydra. You cut one, three more sprout out...

by any example model in Modelica or ModelicaTest. Maybe this should be done by enhancing the example ModelicaTest.Fluid.Dissipation.Verifications.PressureLoss.General.dp_volumeFlowRate_DPMFLOW

We could do it for MSL 4.2.0, see #4585, I really want to release beta.2 tomorrow, so I'm not sure I want to go again through the whole cycle: add PR, ask for reviews, merge on master, back-port, add for review, merge on master, add reference results. Too late now.

@beutlich beutlich added this to the maintenance milestone Mar 11, 2025
@beutlich beutlich changed the title Fixed wrong expression in dp_volumeFlowRate_MFLOW Fix wrong expression in dp_volumeFlowRate_MFLOW Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in dp_volumeFlowRate_MFLOW function

6 participants