This repository was archived by the owner on Jul 8, 2025. It is now read-only.
fix(workspace-manger): do not fall back on a hard-coded encryption key #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odzhychko
force-pushed
the
fix-do-not-fall-back-on-a-hard-coded-encryption-key
branch
2 times, most recently
from
5d9738e to
c7f2e67
Compare
odzhychko
force-pushed
the
fix-do-not-fall-back-on-a-hard-coded-encryption-key
branch
from
c7f2e67 to
b1382fb
Compare
slisson
reviewed
Jul 10, 2024
workspace-manager/src/main/kotlin/org/modelix/workspace/manager/WorkspaceManagerModule.kt
Outdated
Show resolved
Hide resolved
Only attempt to read secret from file. If it fails, do not start up the workspace manager. This should prevent accidental misconfiguration.
odzhychko
force-pushed
the
fix-do-not-fall-back-on-a-hard-coded-encryption-key
branch
from
b1382fb to
3f9bb4e
Compare
slisson
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to read secret from file.
If it fails, do not start up the workspace manager.
This should prevent accidental misconfiguration.