[codex] Update diagnostic package copyright headers#535
Open
[codex] Update diagnostic package copyright headers#535
Conversation
Signed-off-by: Zhao Chen <winters.zc@antgroup.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the copyright headers across multiple files from 'The CNAI Authors' to 'The ModelPack Authors' and moves Go build constraints to the top of the relevant files. Additionally, there is a minor formatting adjustment in the Tracker.Summary method. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/envinfoandpkg/iometricsGo copyright headers from CNAI to ModelPack.Why
PR #523 updated existing files before PR #490 added these diagnostic packages, so the new files kept the old CNAI header. The gofmt changes also resolve the formatting drift tracked in #532.
Closes #532.
Validation
grep -RIn "Copyright 2024 The CNAI Authors" --include='*.go' pkg/envinfo pkg/iometrics || truegofmt -l $(git ls-files '*.go')GOCACHE=$(mktemp -d /tmp/modctl-pr-gocache2.XXXXXX) go test ./pkg/envinfo ./pkg/iometricsGOCACHE=$(mktemp -d /tmp/modctl-pr-gocache-all.XXXXXX) go test ./...