Merged
Conversation
aftersnow
reviewed
Feb 12, 2025
docs/config.md
Outdated
| ```json | ||
| { | ||
| "descriptor": { | ||
| "createTime": "2025-01-01T00:00:00Z", |
Contributor
There was a problem hiding this comment.
The createTime has been change to CreateAt in #31
Contributor
Author
|
Do we need additional restrictions on certain properties, such as "format", "quantization", "parameterSize", "architecture", or even "name"? |
caozhuozi
force-pushed
the
config-md
branch
4 times, most recently
from
73dff1a to
8ccf10c
Compare
Signed-off-by: caozhuozi <543481992@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #27
Some notes for the reviewer:
I haven't imposed any additional restrictions on the
DiffID, as, according to the comment, the format doesn't need to be limited to a cryptographic hash. However, the comment might be outdated, and I'm unsure about the current preference.Do we need a more concrete example instead of a mock one? My concern is that, due to point 1, the format of
DiffIDhas not been determined yet, which makes it difficult to provide a concrete example at this time.I haven't imposed any additional restrictions on the properties in
configaccording to that the current status is not stable yet.