Skip to content

image minimum size set to 16#234

Merged
akaitsuki-ii merged 2 commits into
mainfrom
dev/qz/minimun_size
Feb 10, 2026
Merged

image minimum size set to 16#234
akaitsuki-ii merged 2 commits into
mainfrom
dev/qz/minimun_size

Conversation

@qzzz95

@qzzz95 qzzz95 commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @qzzz95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the qwen_image pipeline by lowering the minimum acceptable image dimension. This adjustment permits the processing or generation of images at significantly smaller resolutions, potentially opening up new applications or accommodating specific model requirements that benefit from very small input sizes.

Highlights

  • Image Size Validation: The minimum allowed image dimension (width or height) for the qwen_image pipeline has been reduced from 64 pixels to 16 pixels.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • diffsynth_engine/pipelines/qwen_image.py
    • Updated the validate_image_size call within the __call__ method to change the minimum dimension parameter from 64 to 16.
Activity
  • The pull request was created by qzzz95.
  • No human activity (comments, reviews) has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the minimum image size from 64 to 16 in the QwenImagePipeline. The change is simple and direct. My review includes one comment pointing out a potential inconsistency where the minimum size for control images has not been updated, which could be an oversight.

if width is None and height is None:
width, height = 1328, 1328
self.validate_image_size(height, width, minimum=64, multiple_of=16)
self.validate_image_size(height, width, minimum=16, multiple_of=16)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly lowers the minimum image size for the main generation, an inconsistency remains. On line 708, the minimum size for in_context control images is still hardcoded to 64. For consistency and to avoid potential issues, it would be best to also update the minimum size for control images to 16, assuming the model supports it.

@akaitsuki-ii akaitsuki-ii merged commit d4809e6 into main Feb 10, 2026
@akaitsuki-ii akaitsuki-ii deleted the dev/qz/minimun_size branch February 10, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants