image minimum size set to 16#234
Conversation
Summary of ChangesHello @qzzz95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reduces the minimum image size from 64 to 16 in the QwenImagePipeline. The change is simple and direct. My review includes one comment pointing out a potential inconsistency where the minimum size for control images has not been updated, which could be an oversight.
| if width is None and height is None: | ||
| width, height = 1328, 1328 | ||
| self.validate_image_size(height, width, minimum=64, multiple_of=16) | ||
| self.validate_image_size(height, width, minimum=16, multiple_of=16) |
There was a problem hiding this comment.
While this change correctly lowers the minimum image size for the main generation, an inconsistency remains. On line 708, the minimum size for in_context control images is still hardcoded to 64. For consistency and to avoid potential issues, it would be best to also update the minimum size for control images to 16, assuming the model supports it.
No description provided.