Krea realtime video by yjy415 · Pull Request #1011 · modelscope/DiffSynth-Studio

yjy415 · 2025-10-27T07:21:15Z

添加了Krea-realtime-video模型的推理和训练脚本，更新了文档

gemini-code-assist · 2025-10-27T07:21:33Z

Summary of Changes

Hello @yjy415, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求全面支持 Krea Realtime Video 模型，包括将其集成到系统中，并提供了用于推理以及全量和 LoRA 训练的专用脚本。它还更新了文档以反映这些新增内容，并包含了一个新的 .gitignore 文件，以改善仓库的整洁度。

Highlights

Krea Realtime Video 模型支持: 添加了对 Krea Realtime Video 模型的全面支持，包括其集成和相关功能。
推理和训练脚本: 为 Krea Realtime Video 模型提供了专用的推理脚本以及全量和 LoRA 训练脚本。
文档更新: 更新了英文和中文的 README 文件，以包含新模型的详细信息和示例链接。
模型加载兼容性: 修改了模型加载逻辑，以确保与新模型状态字典的兼容性，处理 'model.' 前缀问题。
.gitignore 文件: 新增了一个 .gitignore 文件，用于忽略常见的 Python 编译缓存和构建产物。

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

本次代码审查主要关注了新添加的 krea-realtime-video 模型支持。整体来看，PR 成功地集成了新模型，并提供了相应的推理和训练脚本。不过，我发现了一些可以改进的地方：

文档链接：README.md 和 README_zh.md 中新添加的模型表格行包含错误的相对路径，导致链接失效。
代码可读性：在 diffsynth/models/wan_video_dit.py 中，有一段代码可以通过使用字典推导式来写得更简洁。
脚本格式：新添加的 .sh 脚本文件末尾缺少换行符，这不符合 POSIX 规范。
代码整洁度：一些 Python 示例脚本中包含了未使用的导入项。

我已经就这些问题提出了具体的修改建议。修复这些问题将有助于提升代码库的整体质量和可维护性。

gemini-code-assist · 2025-10-27T07:24:28Z

 |[Wan-AI/Wan2.1-VACE-1.3B](https://modelscope.cn/models/Wan-AI/Wan2.1-VACE-1.3B)|`vace_control_video`, `vace_reference_image`|[code](./examples/wanvideo/model_inference/Wan2.1-VACE-1.3B.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-VACE-1.3B.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-VACE-1.3B.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-VACE-1.3B.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-VACE-1.3B.py)|
 |[Wan-AI/Wan2.1-VACE-14B](https://modelscope.cn/models/Wan-AI/Wan2.1-VACE-14B)|`vace_control_video`, `vace_reference_image`|[code](./examples/wanvideo/model_inference/Wan2.1-VACE-14B.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-VACE-14B.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-VACE-14B.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-VACE-14B.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-VACE-14B.py)|
 |[DiffSynth-Studio/Wan2.1-1.3b-speedcontrol-v1](https://modelscope.cn/models/DiffSynth-Studio/Wan2.1-1.3b-speedcontrol-v1)|`motion_bucket_id`|[code](./examples/wanvideo/model_inference/Wan2.1-1.3b-speedcontrol-v1.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-1.3b-speedcontrol-v1.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-1.3b-speedcontrol-v1.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-1.3b-speedcontrol-v1.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-1.3b-speedcontrol-v1.py)|
+|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./model_inference/krea-realtime-video.py)|[code](./model_training/full/krea-realtime-video.sh)|[code](./model_training/validate_full/krea-realtime-video.py)|[code](./model_training/lora/krea-realtime-video.sh)|[code](./model_training/validate_lora/krea-realtime-video.py)|


表格中新添加的模型文件路径不正确，缺少了 examples/wanvideo/ 前缀，这会导致链接失效。请更新路径以确保它们指向正确的文件。

Suggested change

|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./model_inference/krea-realtime-video.py)|[code](./model_training/full/krea-realtime-video.sh)|[code](./model_training/validate_full/krea-realtime-video.py)|[code](./model_training/lora/krea-realtime-video.sh)|[code](./model_training/validate_lora/krea-realtime-video.py)|

|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./examples/wanvideo/model_inference/krea-realtime-video.py)|[code](./examples/wanvideo/model_training/full/krea-realtime-video.sh)|[code](./examples/wanvideo/model_training/validate_full/krea-realtime-video.py)|[code](./examples/wanvideo/model_training/lora/krea-realtime-video.sh)|[code](./examples/wanvideo/model_training/validate_lora/krea-realtime-video.py)|

gemini-code-assist · 2025-10-27T07:24:28Z

 |[Wan-AI/Wan2.1-VACE-1.3B](https://modelscope.cn/models/Wan-AI/Wan2.1-VACE-1.3B)|`vace_control_video`, `vace_reference_image`|[code](./examples/wanvideo/model_inference/Wan2.1-VACE-1.3B.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-VACE-1.3B.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-VACE-1.3B.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-VACE-1.3B.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-VACE-1.3B.py)|
 |[Wan-AI/Wan2.1-VACE-14B](https://modelscope.cn/models/Wan-AI/Wan2.1-VACE-14B)|`vace_control_video`, `vace_reference_image`|[code](./examples/wanvideo/model_inference/Wan2.1-VACE-14B.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-VACE-14B.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-VACE-14B.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-VACE-14B.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-VACE-14B.py)|
 |[DiffSynth-Studio/Wan2.1-1.3b-speedcontrol-v1](https://modelscope.cn/models/DiffSynth-Studio/Wan2.1-1.3b-speedcontrol-v1)|`motion_bucket_id`|[code](./examples/wanvideo/model_inference/Wan2.1-1.3b-speedcontrol-v1.py)|[code](./examples/wanvideo/model_training/full/Wan2.1-1.3b-speedcontrol-v1.sh)|[code](./examples/wanvideo/model_training/validate_full/Wan2.1-1.3b-speedcontrol-v1.py)|[code](./examples/wanvideo/model_training/lora/Wan2.1-1.3b-speedcontrol-v1.sh)|[code](./examples/wanvideo/model_training/validate_lora/Wan2.1-1.3b-speedcontrol-v1.py)|
+|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./model_inference/krea-realtime-video.py)|[code](./model_training/full/krea-realtime-video.sh)|[code](./model_training/validate_full/krea-realtime-video.py)|[code](./model_training/lora/krea-realtime-video.sh)|[code](./model_training/validate_lora/krea-realtime-video.py)|


表格中新添加的模型文件路径不正确，缺少了 examples/wanvideo/ 前缀，这会导致链接失效。请更新路径以确保它们指向正确的文件。

Suggested change

|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./model_inference/krea-realtime-video.py)|[code](./model_training/full/krea-realtime-video.sh)|[code](./model_training/validate_full/krea-realtime-video.py)|[code](./model_training/lora/krea-realtime-video.sh)|[code](./model_training/validate_lora/krea-realtime-video.py)|

|[krea/krea-realtime-video](https://www.modelscope.cn/models/krea/krea-realtime-video)||[code](./examples/wanvideo/model_inference/krea-realtime-video.py)|[code](./examples/wanvideo/model_training/full/krea-realtime-video.sh)|[code](./examples/wanvideo/model_training/validate_full/krea-realtime-video.py)|[code](./examples/wanvideo/model_training/lora/krea-realtime-video.sh)|[code](./examples/wanvideo/model_training/validate_lora/krea-realtime-video.py)|

gemini-code-assist · 2025-10-27T07:24:28Z

+        state_dict_ = {}
+        for name, param in state_dict.items():
+            if name.startswith("model."):
+                name = name[len("model."):]
+            state_dict_[name] = param
+        state_dict = state_dict_


这段代码可以通过使用字典推导式来简化，使其更简洁、更符合Pythonic风格。例如：

state_dict = { (name[len("model."):] if name.startswith("model.") else name): param for name, param in state_dict.items() }

gemini-code-assist · 2025-10-27T07:24:28Z

+  --num_epochs 2 \
+  --remove_prefix_in_ckpt "pipe.dit." \
+  --output_path "./models/train/krea-realtime-video_full" \
+  --trainable_models "dit"


这个脚本文件末尾缺少一个换行符。为了符合POSIX标准并避免在某些shell环境下出现潜在问题，建议在文件末尾添加一个换行符。

Suggested change

--trainable_models "dit"

--trainable_models "dit"

gemini-code-assist · 2025-10-27T07:24:28Z

+  --output_path "./models/train/krea-realtime-video_lora" \
+  --lora_base_model "dit" \
+  --lora_target_modules "q,k,v,o,ffn.0,ffn.2" \
+  --lora_rank 32


这个脚本文件末尾缺少一个换行符。为了符合POSIX标准并避免在某些shell环境下出现潜在问题，建议在文件末尾添加一个换行符。

Suggested change

--lora_rank 32

--lora_rank 32

gemini-code-assist · 2025-10-27T07:24:28Z

+from PIL import Image
+from diffsynth import save_video, VideoData, load_state_dict


导入的 PIL.Image 和 diffsynth.VideoData 在此脚本中并未使用，建议移除以保持代码整洁。

Suggested change

from PIL import Image

from diffsynth import save_video, VideoData, load_state_dict

from diffsynth import save_video, load_state_dict

gemini-code-assist · 2025-10-27T07:24:28Z

+from PIL import Image
+from diffsynth import save_video, VideoData, load_state_dict


导入的 PIL.Image、diffsynth.VideoData 和 diffsynth.load_state_dict 在此脚本中并未使用，建议移除以保持代码整洁。

Suggested change

from PIL import Image

from diffsynth import save_video, VideoData, load_state_dict

from diffsynth import save_video

* krea-realtime-video * Add Krea real-time video inference and training support * Delete .gitignore * update README * update README --------- Co-authored-by: Artiprocher <wangye87v5@hotmail.com> Co-authored-by: Jintao Huang <huangjintao.hjt@alibaba-inc.com> Co-authored-by: Zhongjie Duan <35051019+Artiprocher@users.noreply.github.com>

Artiprocher and others added 2 commits October 27, 2025 10:24

krea-realtime-video

1662b2d

Add Krea real-time video inference and training support

b65b125

gemini-code-assist Bot reviewed Oct 27, 2025

View reviewed changes

Artiprocher and others added 3 commits October 27, 2025 18:58

Delete .gitignore

bb85afc

update README

a59ae93

update README

eb2337e

Artiprocher merged commit e0eabaa into main Oct 27, 2025

Artiprocher deleted the krea-realtime-video branch October 27, 2025 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Krea realtime video#1011

Krea realtime video#1011
Artiprocher merged 5 commits intomainfrom
krea-realtime-video

yjy415 commented Oct 27, 2025

Uh oh!

gemini-code-assist Bot commented Oct 27, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		from PIL import Image
		from diffsynth import save_video, VideoData, load_state_dict

Conversation

yjy415 commented Oct 27, 2025

Uh oh!

gemini-code-assist Bot commented Oct 27, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants