Skip to content

remove some requirements & update Qwen-Image Quickstart#872

Merged
Artiprocher merged 2 commits intomainfrom
dev2-dzj
Aug 29, 2025
Merged

remove some requirements & update Qwen-Image Quickstart#872
Artiprocher merged 2 commits intomainfrom
dev2-dzj

Conversation

@Artiprocher
Copy link
Copy Markdown
Collaborator

No description provided.

@Artiprocher Artiprocher merged commit dea8564 into main Aug 29, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Artiprocher, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's dependency list by removing unneeded packages and adding a new one, while also enhancing the Qwen-Image quickstart documentation. The documentation updates prepare for or demonstrate functionality related to image editing with the Qwen-Image pipeline, making the examples more comprehensive and forward-looking.

Highlights

  • Dependency Management: Removed unnecessary dependencies cupy-cuda12x and controlnet-aux==0.0.7 from requirements.txt to streamline the project's dependencies. Added peft to requirements.txt.
  • Qwen-Image Quickstart Update: Updated the Qwen-Image quickstart examples in both English and Chinese README.md files and their respective examples/qwen_image/README.md files. This includes adding an import for PIL.Image and commenting out an edit_image parameter in the pipe call, indicating future support or example for Qwen-Image-Edit.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the requirements.txt file by removing cupy-cuda12x and controlnet-aux, and adding peft. It also updates the Quickstart examples for Qwen-Image in several README files to demonstrate image editing capabilities. My review focuses on the dependency changes. I've pointed out a documentation inconsistency related to the cupy removal and raised a concern about the potential impact of removing controlnet-aux on existing examples. The updates to the README examples are clear and helpful.

Comment thread requirements.txt
torchvision
cupy-cuda12x
transformers
controlnet-aux==0.0.7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The controlnet-aux dependency is being removed. This package is often used for preprocessing in ControlNet examples (e.g., for Canny edge detection). Please ensure that this dependency is no longer used in any of the ControlNet examples to avoid breaking them for users.

Comment thread requirements.txt
@@ -1,8 +1,6 @@
torch>=2.0.0
torchvision
cupy-cuda12x
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

cupy-cuda12x has been removed, but the main README.md and README_zh.md files still list cupy as a dependency to check during installation. To avoid confusion, please also remove the mention of cupy from the documentation if it's no longer required.

LPY1219 pushed a commit to LPY1219/DiffSynth-Studio that referenced this pull request Oct 3, 2025
remove some requirements & update Qwen-Image Quickstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant