[bugfix] fix set_module lora#33
Merged
Jintao-Huang merged 4 commits intomodelscope:mainfrom Apr 16, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the _set_module method in gpt_bridge.py to track PEFT target modules and modules to save by extracting them from the state dictionary keys. A review comment pointed out that the string splitting logic for extracting these module names is fragile and could fail if the separator is not found, suggesting a more robust implementation.
Collaborator
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the gpt_bridge.py file to track PEFT target modules and modules to save by parsing module names from state dictionary keys. The review feedback suggests refactoring the extraction logic to eliminate code duplication and improve maintainability.
Jintao-Huang
added a commit
that referenced
this pull request
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.