fix: Add is_mtp parameter to _set_moe_state avoid type error#45
Merged
Jintao-Huang merged 2 commits intomodelscope:mainfrom Apr 21, 2026
Merged
fix: Add is_mtp parameter to _set_moe_state avoid type error#45Jintao-Huang merged 2 commits intomodelscope:mainfrom
Jintao-Huang merged 2 commits intomodelscope:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an is_mtp parameter to the _set_moe_state method in minimax_m2.py. The review feedback suggests adding a default value of False to this parameter to maintain consistency with the base class and ensuring the parameter is correctly passed to the superclass method call to prevent logic errors.
Contributor
Author
|
关联isssue #44 |
1 task
Jintao-Huang
approved these changes
Apr 21, 2026
Collaborator
|
thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinimaxM2Bridge类继承了GPTBridge类,但是其_set_moe_state的签名与GPTBridge类的不一致,缺少is_mtp变量。导致报错TypeError: MinimaxM2Bridge._set_moe_state() got an unexpected keyword argument 'is_mtp'。
这里由于MinimaxM2Bridge类的_set_moe_state方法体没有实际使用is_mtp变量,且在GPTBridge类中有mtp处理逻辑,所以直接在形参中添加is_mtp变量即可。
修改后,在NPU测试可正常训练Minimax M2.5。