compat python 3.13#68
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates setup.py to use a regular expression for extracting the package version instead of executing the version file. Feedback indicates that the current regex implementation could lead to an AttributeError if no match is found and contains a potentially incorrect character set for quotes; a more robust implementation with error handling was suggested.
| with open(version_file, 'r', encoding='utf-8') as f: | ||
| exec(compile(f.read(), version_file, 'exec')) | ||
| return locals()['__version__'] | ||
| return re.search(r'^__version__\s*=\s*["\'](.+?)["\']', f.read(), re.M).group(1) |
There was a problem hiding this comment.
The current implementation has two potential issues:
- It will raise an
AttributeErrorifre.searchreturnsNone(i.e., the version string is not found), which will crash the setup process. - The regex character set
["\']is likely incorrect. It matches a double quote, a backslash, or a single quote. The intention is likely to match only a double or single quote, which would be["'].
A more robust implementation would handle the None case and use the correct regex.
Suggested change
| return re.search(r'^__version__\s*=\s*["\'](.+?)["\']', f.read(), re.M).group(1) | |
| match = re.search(r"""^__version__\s*=\s*["'](.+?)["']""", f.read(), re.M) | |
| if not match: | |
| raise RuntimeError('Unable to find version string.') | |
| return match.group(1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.