Skip to content

compat lint py313#69

Merged
Jintao-Huang merged 1 commit into
modelscope:mainfrom
Jintao-Huang:compat_lint_py313
May 8, 2026
Merged

compat lint py313#69
Jintao-Huang merged 1 commit into
modelscope:mainfrom
Jintao-Huang:compat_lint_py313

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .pre-commit-config.yaml file by bumping the isort version and migrating the yapf hook to its official repository with an updated version. Feedback indicates that the specified isort version 8.0.1 is invalid and should be corrected to a valid version like 6.0.0 to ensure compatibility and prevent installation failures.

Comment thread .pre-commit-config.yaml
- id: flake8
- repo: https://github.com/PyCQA/isort.git
rev: 8.0.0
rev: 8.0.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 8.0.1 for isort does not exist in the official PyCQA/isort repository. To achieve compatibility with Python 3.13 as intended by this pull request, you should use version 6.0.0 or later, which is the first major version to officially support Python 3.13. Using a non-existent revision will cause the pre-commit hook to fail during installation.

    rev: 6.0.0

@Jintao-Huang Jintao-Huang merged commit b94dee4 into modelscope:main May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant