remove hf_grouped lora error#75
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables support for Hugging Face grouped LoRA in the GPT bridge by adding a support flag and replacing strict ValueErrors with informative warnings when LoRA weight conversion is not directly supported. Feedback focuses on correcting minor formatting issues in the warning messages, such as punctuation placement and spacing, and suggests refactoring the duplicated warning string into a shared constant to improve maintainability.
| 'You can solve this issue by setting `--merge_lora true`.') | ||
| logger.warning_once( | ||
| 'Since this model\'s transformers and megatron have different expert weight organization ' | ||
| 'methods, LoRA weights may not be available for inference. It is recommended to set ' |
There was a problem hiding this comment.
There's a minor formatting issue in the warning message. The period for --merge_lora true should be outside the backticks, and a space is needed before the next sentence for better readability.
| 'methods, LoRA weights may not be available for inference. It is recommended to set ' | |
| 'methods, LoRA weights may not be available for inference. It is recommended to set `--merge_lora true`. ' |
| 'weight organization methods, LoRA weight conversion is not supported. ' | ||
| 'You can solve this issue by setting `--merge_lora true`.') | ||
| logger.warning_once( | ||
| 'Since this model\'s transformers and megatron have different expert weight organization ' |
There was a problem hiding this comment.
This warning message is duplicated from earlier in the function (around line 944). To improve maintainability, consider extracting the message into a shared constant.
Additionally, this instance has the same formatting issue as the first one: the period should be outside the backticks for --merge_lora true, and a space is needed before the next sentence.
| 'Since this model\'s transformers and megatron have different expert weight organization ' | |
| 'methods, LoRA weights may not be available for inference. It is recommended to set `--merge_lora true`. ' |
1 participant
No description provided.