Skip to content

[model] support qwen3_asr#78

Merged
Jintao-Huang merged 3 commits into
modelscope:mainfrom
Jintao-Huang:support_qwen3_asr
May 14, 2026
Merged

[model] support qwen3_asr#78
Jintao-Huang merged 3 commits into
modelscope:mainfrom
Jintao-Huang:support_qwen3_asr

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Qwen3-ASR model, including its bridge implementation, audio feature handling, and registration. It also refactors the multimodal type detection by replacing the boolean support_multimodal flag with a more specific test_mm_type attribute (e.g., 'image', 'audio', 'text') across the model configuration and various model classes. A new test case for qwen3_asr has been added to the test suite. The review feedback suggests improving the robustness of the audio feature handling in qwen3_asr.py by using the dynamic batch size from input_ids instead of a hardcoded value for dummy inputs.

Comment thread src/mcore_bridge/model/mm_gpts/qwen3_asr.py
@Jintao-Huang
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the qwen3_asr model, including the implementation of the Qwen3ASRBridge and Qwen3ASRVit classes. It refactors the multimodal configuration by replacing the support_multimodal boolean with a test_mm_type attribute to better distinguish between input types like 'image', 'audio', and 'text'. Additionally, it includes a fix in gpt_model.py to expand position_ids when using 'mrope' embeddings. A review comment correctly identified a potential AttributeError in the new qwen3_asr.py file where a module's .dtype was accessed, suggesting the use of self.config.params_dtype instead.

Comment thread src/mcore_bridge/model/mm_gpts/qwen3_asr.py
@Jintao-Huang Jintao-Huang merged commit 7aad53a into modelscope:main May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants