Conversation
🦋 Changeset detectedLatest commit: 8a7c750 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request synchronizes dependencies to antd 6.4.0 and antdx 2.7.0, while also introducing several new component properties and slot supports across the library. Key changes include the addition of variant to Alert, target_offset to Anchor.Item, and searchIcon support for Cascader and Input.Search. Additionally, several React components were refactored to use useMemo and useRef for more efficient state management and to avoid unnecessary re-renders. During the review, a critical bug was identified in the Cascader backend definition where a missing comma would cause string concatenation of slot names. Furthermore, an incorrect ESLint suppression comment was found in the bubble list utilities that should be removed.
| 'notFoundContent', 'expandIcon', 'removeIcon', 'prefix', | ||
| 'displayRender', 'tagRender', 'dropdownRender', 'popupRender' | ||
| 'notFoundContent', 'expandIcon', 'removeIcon', 'showSearch.searchIcon', | ||
| 'prefix', 'displayRender', 'tagRender', 'dropdownRender', 'popupRender' |
There was a problem hiding this comment.
There is a missing comma at the end of this line. In Python, adjacent string literals are automatically concatenated if not separated by a comma. This will result in 'popupRendershowSearch.render' instead of two separate slot names. Please add a comma to separate them.
| 'prefix', 'displayRender', 'tagRender', 'dropdownRender', 'popupRender' | |
| 'prefix', 'displayRender', 'tagRender', 'dropdownRender', 'popupRender', |
| }, | ||
| } | ||
| ); | ||
| // eslint-disable-next-line react-hooks/use-memo |
There was a problem hiding this comment.
The ESLint suppression comment refers to a non-existent rule react-hooks/use-memo. If the intention was to suppress dependency warnings, react-hooks/exhaustive-deps is already used on line 130. This line appears to be a typo and should be removed.
1 participant
No description provided.