-
Notifications
You must be signed in to change notification settings - Fork 433
fix docling version #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docling version #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a dependency versioning concern by specifying an upper bound for the docling package in the research environment's requirements. This change aims to ensure stability and compatibility by preventing unintended upgrades to newer, potentially breaking, versions of the docling library.
Highlights
- Dependency Management: I've updated the
requirements/research.txtfile to explicitly pin thedoclingpackage to version2.38.1or earlier. This changes the dependency from an unversioneddoclingtodocling<=2.38.1.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the version for the docling dependency to prevent potential breakages from future releases. This is a good practice. My review includes a suggestion to use an exact version pin for better reproducibility, which is especially important given that the codebase patches the docling library and is therefore sensitive to its internal implementation.
| @@ -1,4 +1,4 @@ | |||
| docling | |||
| docling<=2.38.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning the docling version is a good practice for ensuring build reproducibility. However, using <= allows installation of any version up to 2.38.1. This could potentially allow older, incompatible versions to be installed if the code relies on features from a newer patch release within the 2.38.x series.
Given that the codebase uses patching on docling internals (as seen in ms_agent/tools/docling/doc_loader.py), the system is likely sensitive to even minor changes in the library. To ensure maximum stability and prevent unexpected breakages, it's strongly recommended to pin to an exact version using ==. This guarantees that the exact same version of the dependency is used across all environments.
docling==2.38.1
No description provided.