fix: flaky test case

[suluyana]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @suluyana, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves flakiness in several test cases by refining the test setup and execution logic. It removes arbitrary time.sleep() delays that were temporary solutions for API rate limiting, and introduces a more robust mcp_client warmup procedure to ensure consistent test environments. These modifications collectively enhance the stability and reliability of the test suite, leading to more dependable and accurate test results.

Highlights

• Test Stability Improvements: Eliminated several time.sleep() calls from various test cases, which were previously used as workarounds for ModelScope API rate limiting. This change aims to reduce test flakiness and improve execution speed.
• MCPClient Warmup: Introduced an asynchronous setUp method in test_anthropic.py to connect to and warm up the mcp_client before tests run, ensuring that tools are available and the client is in a consistent state.
• Resource Management Refinement: Removed an explicit client.close() call from test_default_memory.py, potentially streamlining resource handling and preventing issues related to premature client closure within test contexts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix flaky tests by removing time.sleep calls and adding a server warm-up in a setUp method. While the approach is sound, I've identified a critical issue in the new setUp method in tests/llm/test_anthropic.py where a configuration object is used before it's defined, which will cause tests to fail. Additionally, I've noted a potential resource leak in tests/memory/test_default_memory.py from a removed client cleanup call and a minor style issue with import placement. Addressing these points will improve the robustness and quality of the tests.