Skip to content

Fix gif link in agent skills docs#771

Merged
wangxingjun778 merged 5 commits intomainfrom
release/1.4
Nov 7, 2025
Merged

Fix gif link in agent skills docs#771
wangxingjun778 merged 5 commits intomainfrom
release/1.4

Conversation

@wangxingjun778
Copy link
Copy Markdown
Collaborator

No description provided.

@wangxingjun778 wangxingjun778 merged commit 3420c82 into main Nov 7, 2025
2 of 4 checks passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a GIF image was not displaying correctly in the agent skills documentation. It updates the image embedding method from an HTML-based structure to a standard Markdown image link, ensuring the GIF is correctly displayed by referencing a local resource. This improves the readability and accuracy of the documentation for both English and Chinese versions.

Highlights

  • Documentation Fix: Corrected a broken GIF link within the agent skills documentation for both English and Chinese versions.
  • Image Embedding Method: Refactored the image embedding from an HTML div and img tag structure to a more concise and standard Markdown image syntax.
  • Resource Path Update: Updated the GIF reference to use a relative path (../../resources/skill_algorithmic_art_result.gif), ensuring the image is loaded correctly from local resources.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for agent skills in both Chinese and English to use a relative path for a GIF, which is a good improvement for repository maintenance. My review includes suggestions to restore the image captions that were removed during this change, as they provide valuable context. For the Chinese documentation, I've also suggested translating the caption.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the image link to a relative path is a good improvement. However, this change removed the image caption, which provided useful context. I suggest adding it back in Markdown format. Since this is a Chinese document, the caption should also be translated. For example: 智能体技能:流场粒子效果. Also, note that the width attribute was removed, which might affect how the image is displayed. If controlling the width is important, you might need to stick with the HTML <img> tag.

Suggested change
![Flow Field Particles](../../resources/skill_algorithmic_art_result.gif)
![Flow Field Particles](../../resources/skill_algorithmic_art_result.gif)
*智能体技能:流场粒子效果*

<img src="https://github.com/user-attachments/assets/9d5d78bf-c2db-4280-b780-324eab74a41e" alt="FlowFieldParticles" width="750">
<p><em>Agent-Skills: Flow Field Particles</em></p>
</div>
![Flow Field Particles](../../resources/skill_algorithmic_art_result.gif)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the image link to a relative path is a good improvement. However, this change removed the image caption Agent-Skills: Flow Field Particles, which provided useful context. I suggest adding it back in Markdown format. Also, note that the width attribute was removed, which might affect how the image is displayed. If controlling the width is important, you might need to stick with the HTML <img> tag.

Suggested change
![Flow Field Particles](../../resources/skill_algorithmic_art_result.gif)
![Flow Field Particles](../../resources/skill_algorithmic_art_result.gif)
*Agent-Skills: Flow Field Particles*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant