Skip to content

fix grpo vllm tp #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix grpo vllm tp #3658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions swift/trainers/rlhf_trainer/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,8 +707,6 @@ def _infer_multi_turn(self, inputs_slice, request_config) -> List[List[Dict[str,
outputs.append(_choices)
assert len(outputs) == prompt_lens
assert all([len(o) == self.args.tensor_parallel_size for o in outputs])
if isinstance(outputs[0][0], list):
outputs = [output[0] for output in outputs]
return outputs

def async_infer(self, inputs, inputs_slice, distributed_idx):
Expand Down Expand Up @@ -832,6 +830,8 @@ def _generate_and_score_completions(
self.model.train()
if is_multimodal:
self.template.register_post_encode_hook(models)
if isinstance(outputs[0][0], list):
outputs = [output[0] for output in outputs]

# Slice to keep only the local part of the data
process_slice = slice(
Expand Down
Loading