[grpo] Refactor GRPOVllmEngine #4375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jintao-Huang
approved these changes
May 27, 2025
tastelikefeet
approved these changes
May 27, 2025
Jintao-Huang
approved these changes
May 27, 2025
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
May 27, 2025
…o_padding_ulysses * commit '6dc42ab56e19fd4485e0fb0309d5552b2a1d35d8': [grpo] Refactor GRPOVllmEngine (modelscope#4375) [dist] fix ddp_timeout (modelscope#4373) [dataset] fix LazyLLMDataset random (modelscope#4369) [callback] fix logger (modelscope#4367) [infer/deploy] vllm use v1 engine & support write_batch_size & support vllm tp & dp (modelscope#4345) [infer] vllm remove Cached (modelscope#4354)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
replace LLM with LLMEngine (super) for future support of AsyncLLMEngine after #4345
Experiment results
Paste your experiment result here(if needed).