-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix special str and value type for web-ui #5632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix special str and value type for web-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @slin000111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses two distinct issues within the web user interface: one related to the display of special characters in the chatbot, and another concerning the accurate type conversion of values from slider components. These fixes enhance the stability and correctness of the UI's interaction and data presentation.
Highlights
- Web-UI Chatbot Special Character Handling: Implemented a new method to escape special characters (<, >, *) in chatbot messages, preventing rendering issues in the web UI.
- Gradio Slider Value Type Correction: Ensured that values from Gradio Slider components are correctly parsed and converted to their appropriate numeric types (integer or float).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix two issues: escaping special characters for the web UI and handling slider value types. The changes are in the right direction, but they introduce new potential runtime errors. In llm_infer.py, the new parse_text method doesn't handle None values, which can lead to an AttributeError. In runtime.py, the regex for float validation is too permissive and can cause a ValueError when converting certain strings to float. I've provided suggestions to make these changes more robust.
| query = message[0].replace('<', '<').replace('>', '>').replace('*', '*') | ||
| response = message[1].replace('<', '<').replace('>', '>').replace('*', '*') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _replace_tag_with_media method can return None for the response part of a message tuple. This will cause an AttributeError when .replace() is called on a None value. It's safer to check if the items are strings before attempting to call string methods on them.
| query = message[0].replace('<', '<').replace('>', '>').replace('*', '*') | |
| response = message[1].replace('<', '<').replace('>', '>').replace('*', '*') | |
| query = message[0].replace('<', '<').replace('>', '>').replace('*', '*') if isinstance(message[0], str) else message[0] | |
| response = message[1].replace('<', '<').replace('>', '>').replace('*', '*') if isinstance(message[1], str) else message[1] |
| elif isinstance(e, gr.Slider) and re.fullmatch(cls.float_regex, all_args[e.elem_id]): | ||
| arg = float(all_args[e.elem_id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex cls.float_regex can match strings that are not valid floats (e.g., a single dot .), which will cause float() to raise a ValueError and crash the application. Using a try-except block for the conversion is a more robust way to handle such cases gracefully.
elif isinstance(e, gr.Slider) and re.fullmatch(cls.float_regex, all_args[e.elem_id]):
try:
arg = float(all_args[e.elem_id])
except ValueError:
arg = all_args[e.elem_id]
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).