-
Notifications
You must be signed in to change notification settings - Fork 904
Fix sp non-padding-free #5906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sp non-padding-free #5906
Conversation
Summary of ChangesHello @tastelikefeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's capabilities for reranker and sequence classification tasks, particularly focusing on improved integration with the vLLM inference engine. It introduces a new control for reranker activation, adds support for a popular family of reranker models, and provides practical deployment examples. Additionally, it includes a critical fix for sequence parallelism, enhancing overall stability and functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily introduces support for reranker models, including BGE and Qwen3 generative rerankers, and enhances sequence classification capabilities with the vLLM backend. It also contains a fix for sequence parallelism in non-padding-free mode. The changes are comprehensive, including necessary documentation updates and new examples. My review includes a couple of suggestions to improve code modularity and clarity, mainly by encapsulating model-specific logic within template classes.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).