Skip to content

Fix sp non-padding-free #5906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 22, 2025
Merged

Fix sp non-padding-free #5906

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2956bfc
wip
Sep 19, 2025
32721d4
Merge branch 'main' of github.com:tastelikefeet/swift
Sep 19, 2025
c7c0071
fix
Sep 20, 2025
cecd056
Merge commit 'c25d275c930dcaa1358c3fe72c8d52423b00e32b' into feat/rer…
tastelikefeet Sep 20, 2025
4914e42
lint
tastelikefeet Sep 20, 2025
8cae1bb
fix
Sep 20, 2025
a026592
docs
Sep 20, 2025
d4acbf4
add new files
Sep 20, 2025
e65440c
liknt
Sep 20, 2025
2073bd4
fix
Sep 20, 2025
d39e55a
fix
Sep 22, 2025
09fceb7
Merge remote-tracking branch 'origin/main' into fix/sp-pos-0922
Sep 22, 2025
364ebe4
fix
Sep 22, 2025
bf7e561
fix
Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions swift/trainers/sequence_parallel/ulysses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,10 +703,9 @@ def prepare_inputs(self, inputs):
2. split labels
"""
position_ids = None
if self.padding_free:
position_ids = inputs.get('text_position_ids')
if position_ids is None:
position_ids = inputs.get('position_ids')
position_ids = inputs.get('text_position_ids')
if position_ids is None:
position_ids = inputs.get('position_ids')
if position_ids is not None and position_ids.shape[0] == 1:
self.extra_kwargs['text_position_ids'] = position_ids.clone()
if 'labels' in inputs:
Expand Down