[bugfix] patch timeout & fix print_rich_table

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two distinct issues: one related to network operation timeouts and another concerning the robustness of data visualization. It introduces a timeout patching mechanism to prevent modelscope API calls from hanging indefinitely during model checks, ensuring a more responsive application. Additionally, it enhances the stability of the reward trainer by adding error handling to the print_rich_table function, preventing crashes when displaying data.

Highlights

• Timeout Patching: Implemented a mechanism to limit the timeout for modelscope.hub.api.HubApi initialization to a maximum of 5 seconds, preventing potential long waits during model checks.
• Robust Table Printing: Added error handling around print_rich_table calls in the reward trainer to catch and log exceptions, improving the stability of the visualization process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two bug fixes: one to patch the timeout for check_local_model_is_latest to prevent long hangs, and another to add error handling for print_rich_table to improve robustness. The changes are sensible and address the intended issues. My feedback focuses on improving maintainability by replacing a magic number with a constant and refining the exception handling to be more specific.

[gemini-code-assist]

Using a magic number like 5 for the timeout cap makes the code harder to understand and maintain. It's better to define it as a named constant (e.g., _HUB_API_TIMEOUT_CAP = 5) at the beginning of the method or at the class level. This clarifies the purpose of the value and makes it easier to find and change if needed.

[gemini-code-assist]

Catching a broad Exception can mask underlying issues and might unintentionally catch system-exiting exceptions like KeyboardInterrupt. It's generally safer to catch more specific exceptions. If the goal is to catch any error related to table printing, consider catching a tuple of likely exceptions, such as (ValueError, TypeError, ImportError), or at least re-raising system-level exceptions.